[yugabyte#27992] YSQL: Use __lsan_ignore_object instead of lsan-supressions.txt for postgres code

Summary:
Sometimes (possible after update to clang 19) address sanitizer fails to symbolize leak stack trace:
```
==85768==WARNING: Can't read from symbolizer at fd 5
==85768==WARNING: Can't read from symbolizer at fd 5
==85768==WARNING: Can't read from symbolizer at fd 5
==85768==WARNING: Can't read from symbolizer at fd 5
==85768==WARNING: Can't read from symbolizer at fd 5
    #0 0x5580d4be8bba  (${BUILD_ROOT}/postgres/bin/postgres+0xef0bba)
    #1 0x5580d587cc4c  (${BUILD_ROOT}/postgres/bin/postgres+0x1b84c4c)
    #2 0x5580d55be5cc  (${BUILD_ROOT}/postgres/bin/postgres+0x18c65cc)
    #3 0x5580d55be171  (${BUILD_ROOT}/postgres/bin/postgres+0x18c6171)
    #4 0x7fc9991e57e4  (/lib64/libc.so.6+0x3a7e4) (BuildId: 889235a2805b8308b2d0274921bbe1890e9a1986)
```

While actually this stack trace contains supresseed function (postmaster_strdup in this particular scenario), it cannot obtain function name, so detected leak is propagated and test fails.

Replaced lsan-suppressions.txt entries with code annotations using `__lsan_ignore_object` to address this issue.

Also cleaned up lsan-supressions.txt and resolved issue yugabyte#27496 by adding missing call to YBCFreeStatus.
Jira: DB-17615

Test Plan: ./yb_build.sh asan --cxx-test pgwrapper_pg_wait_on_conflict-test --gtest_filter PgTabletSplittingWaitQueuesTest.SplitTablet -n 200 -- -p 8

Reviewers: dmitry, esheng, rthallam

Reviewed By: dmitry, esheng, rthallam

Subscribers: rthallam, ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D45426

Author: spolitov

build-support/lsan-suppressions.txt

@@ -27,11 +27,7 @@ leak:__res_vinit
 # In general, PostgreSQL has not yet been adapted to run correctly with LSAN
 # as of 09/2018.
 
-leak:save_ps_display_args
-leak:pg_malloc_internal
-leak:escape_single_quotes_ascii
 leak:gaih_inet
-leak:pg_strdup
 
 # When we push down PG/YSQL expression execution we prepare long-lived, thread-local memory
 # contexts in DocDB to use for evaluating the expressions. These contexts are never deleted, only
@@ -41,13 +37,6 @@ leak:YbgPrepareMemoryContext
 # https://gist.githubusercontent.com/mbautin/015cb594c8281e1afc7ee7b3b5230fce/raw
 leak:__strdup
 
-# https://gist.githubusercontent.com/mbautin/864e341c578f30b478da93f59cf098cc/raw
-leak:guc_strdup
-leak:postmaster_strdup
-
-# https://github.com/yugabyte/yugabyte-db/issues/27496
-leak:CloneAndAddErrorCode
-
 # https://github.com/yugabyte/yugabyte-db/issues/14745
 leak:ThreadSafeObjectPool
 

src/postgres/src/backend/access/yb_access/yb_scan.c

@@ -4064,12 +4064,16 @@ HandleExplicitRowLockStatus(YbcPgExplicitRowLockStatus status)
 	if (status.error_info.is_initialized &&
 		YBCIsExplicitRowLockConflictStatus(status.ybc_status))
 	{
+		YBCFreeStatus(status.ybc_status);
 		YBCHandleConflictError((OidIsValid(status.error_info.conflicting_table_id) ?
 								RelationIdGetRelation(status.error_info.conflicting_table_id) :
 								NULL),
 							   status.error_info.pg_wait_policy);
 	}
-	HandleYBStatus(status.ybc_status);
+	else
+	{
+		HandleYBStatus(status.ybc_status);
+	}
 }
 
 /*

src/postgres/src/backend/postmaster/postmaster.c

@@ -149,6 +149,7 @@
 #include "storage/procarray.h"
 #include "storage/procsignal.h"
 #include "storage/sinvaladt.h"
+#include "yb/util/debug/leak_annotations.h"
 #include "yb/yql/pggate/ybc_pg_shared_mem.h"
 #include "yb_ash.h"
 #include "yb_query_diagnostics.h"
@@ -598,7 +599,9 @@ HANDLE		PostmasterHandle;
 char *
 postmaster_strdup(const char *in)
 {
-	return strdup(in);
+	char *result = strdup(in);
+	__lsan_ignore_object(result);
+	return result;
 }
 
 /*

src/postgres/src/backend/utils/misc/guc.c

@@ -123,6 +123,7 @@
 #include "pg_yb_utils.h"
 #include "tcop/pquery.h"
 #include "utils/syscache.h"
+#include "yb/util/debug/leak_annotations.h"
 #include "yb_ash.h"
 #include "yb_query_diagnostics.h"
 #include "yb_tcmalloc_utils.h"
@@ -7332,6 +7333,7 @@ guc_strdup(int elevel, const char *src)
 		ereport(elevel,
 				(errcode(ERRCODE_OUT_OF_MEMORY),
 				 errmsg("out of memory")));
+	__lsan_ignore_object(data);
 	return data;
 }
 

src/postgres/src/backend/utils/misc/ps_status.c

@@ -32,6 +32,9 @@
 #include "utils/guc.h"
 #include "utils/ps_status.h"
 
+/* YB includes */
+#include "yb/util/debug/leak_annotations.h"
+
 extern char **environ;
 bool		update_process_title = true;
 
@@ -113,6 +116,15 @@ static size_t ps_buffer_fixed_size; /* size of the constant prefix */
 static int	save_argc;
 static char **save_argv;
 
+#if defined(PS_USE_CLOBBER_ARGV)
+static char **
+allocate_new_environ(int i)
+{
+  char **result = (char **) malloc((i + 1) * sizeof(char *));
+  __lsan_ignore_object(result);
+  return result;
+}
+#endif
 
 /*
  * Call this early in startup to save the original argc/argv values.
@@ -202,7 +214,7 @@ save_ps_display_args(int argc, char **argv)
 		/*
 		 * move the environment out of the way
 		 */
-		new_environ = (char **) malloc((i + 1) * sizeof(char *));
+		new_environ = allocate_new_environ(i);;
 		if (!new_environ)
 		{
 			write_stderr("out of memory\n");

src/postgres/src/common/fe_memutils.c

@@ -19,6 +19,9 @@
 
 #include "postgres_fe.h"
 
+/* YB includes */
+#include "yb/util/debug/leak_annotations.h"
+
 static inline void *
 pg_malloc_internal(size_t size, int flags)
 {
@@ -40,6 +43,8 @@ pg_malloc_internal(size_t size, int flags)
 
 	if ((flags & MCXT_ALLOC_ZERO) != 0)
 		MemSet(tmp, 0, size);
+
+	__lsan_ignore_object(tmp);
 	return tmp;
 }
 
@@ -98,6 +103,7 @@ pg_strdup(const char *in)
 		fprintf(stderr, _("out of memory\n"));
 		exit(EXIT_FAILURE);
 	}
+	__lsan_ignore_object(tmp);
 	return tmp;
 }
 

src/postgres/src/port/quotes.c

@@ -15,6 +15,9 @@
 
 #include "c.h"
 
+/* YB includes */
+#include "yb/util/debug/leak_annotations.h"
+
 /*
  * Escape (by doubling) any single quotes or backslashes in given string
  *
@@ -47,5 +50,6 @@ escape_single_quotes_ascii(const char *src)
 		result[j++] = src[i];
 	}
 	result[j] = '\0';
+	__lsan_ignore_object(result);
 	return result;
 }

src/yb/util/debug/leak_annotations.h

@@ -32,9 +32,12 @@
 #pragma once
 
 // API definitions from LLVM lsan_interface.h
-
+#ifdef __cplusplus
 extern "C" {
-  // Allocations made between calls to __lsan_disable() and __lsan_enable() will
+#endif
+
+#if defined(ADDRESS_SANITIZER)
+    // Allocations made between calls to __lsan_disable() and __lsan_enable() will
   // be treated as non-leaks. Disable/enable pairs may be nested.
   void __lsan_disable();
   void __lsan_enable();
@@ -52,10 +55,23 @@ extern "C" {
   // most once per process. This function will terminate the process if there
   // are memory leaks and the exit_code flag is non-zero.
   void __lsan_do_leak_check();
+#elif defined(__cplusplus)
+  inline void __lsan_disable() {}
+  inline void __lsan_enable() {}
+  inline void __lsan_ignore_object(const void *p) {}
+#else
+  static void __lsan_disable() {}
+  static void __lsan_enable() {}
+  static void __lsan_ignore_object(const void *p) {}
+#endif
+
+#ifdef __cplusplus
 }  // extern "C"
+#endif
+
+#ifdef __cplusplus
 
-namespace yb {
-namespace debug {
+namespace yb::debug {
 
 class ScopedLSANDisabler {
  public:
@@ -76,5 +92,6 @@ class ScopedLSANDisabler {
   }
 };
 
-} // namespace debug
-} // namespace yb
+} // namespace yb::debug
+
+#endif

src/yb/util/debug/leakcheck_disabler.h

@@ -31,11 +31,12 @@
 //
 #pragma once
 
-#include "yb/gutil/macros.h"
 #include "yb/util/debug/leak_annotations.h"
 
-namespace yb {
-namespace debug {
+#ifdef __cplusplus
+#include "yb/gutil/macros.h"
+
+namespace yb::debug {
 
 // Scoped object that generically disables LSAN leak checking in a given scope.
 // While this object is alive, calls to "new" will not be checked for leaks.
@@ -49,23 +50,21 @@ class ScopedLeakCheckDisabler {
   DISALLOW_COPY_AND_ASSIGN(ScopedLeakCheckDisabler);
 };
 
+} // namespace yb::debug
+
+#endif
+
 #if defined(__has_feature)
   #if __has_feature(address_sanitizer)
     #define DISABLE_ASAN __attribute__((no_sanitize("address")))
+    #define DISABLE_UBSAN __attribute__((no_sanitize("undefined")))
   #endif
 #endif
+
 #ifndef DISABLE_ASAN
 #define DISABLE_ASAN
 #endif
 
-#if defined(__has_feature)
-  #if __has_feature(address_sanitizer)
-    #define DISABLE_UBSAN __attribute__((no_sanitize("undefined")))
-  #endif
-#endif
 #ifndef DISABLE_UBSAN
 #define DISABLE_UBSAN
 #endif
-
-} // namespace debug
-} // namespace yb

src/yb/yql/pggate/pg_perform_future.cc

@@ -36,7 +36,7 @@ Status PatchStatus(const Status& status, const PgObjectIds& relations) {
     const auto& actual_status =
         PgsqlRequestStatus(status) == PgsqlResponsePB::PGSQL_STATUS_DUPLICATE_KEY_ERROR
           ? duplicate_key_status : status;
-    return  actual_status.CloneAndAddErrorCode(RelationOid(relations[op_index].object_oid));
+    return actual_status.CloneAndAddErrorCode(RelationOid(relations[op_index].object_oid));
   }
   return status;
 }