Add exponential_backoff_error_timeout feature #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulRahmanAlHamali
force-pushed
the
exponential-backoff-error-timeout
branch
2 times, most recently
from
1b581d1 to
f627e01
Compare
AbdulRahmanAlHamali
force-pushed
the
exponential-backoff-error-timeout
branch
from
f627e01 to
4abbaaa
Compare
Aguasvivas22
approved these changes
Nov 10, 2025
Aguasvivas22
left a comment
Aguasvivas22
left a comment
There was a problem hiding this comment.
LGTM! Though it would've been great to have the testing setup from pid-take-2 to help visualize the differences with and without the backoff feature in difference scenarios.
Contributor
Author
|
Agreed. Maybe we can port the classic circuit breaker experiments that we already have into main |
kris-gaudel
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #834, but doesn't fully replace the concept of error_timeout (as the issue suggests).
Instead, the user still provides
error_timeout, and the feature is just to provide a boolean that allows us to creep towards it. Once we reach it, we go back to the original behaviour.I also allow the user to specify the starting point, and the exponential factors. Tbh I doubt people would change those values that often, but wanted to keep this option available since this is an open source library