-
-
Notifications
You must be signed in to change notification settings - Fork 265
Description
Hi,
Looking into the Trading System in a bit more detail, unless I'm missing something I don't think this can really work as it is at present.
Using the phigh/plow feature you run into the problem that predictions are loaded from the training run which are a consolidated list of predictions for the entire group. The system then tries to join these predictions with the price data for a single stock symbol which leads to a mismatch.
It seems that it would be better if the Trading System made its own predictions using a pre-trained model for each of the stock symbols that it iterates through. I can't see any obvious way to join the predictions back with the stock symbols, running a separate prediction would avoid this problem and mean that the Trading System could be run on new test data without running the whole training cycle.
I'm thinking of looking into this, but before I leap in, it would be good to know what the consensus is on this...?