Skip to content

Conversation

@debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jul 16, 2025

closes #69

@debdutdeb debdutdeb force-pushed the one-serverResolution branch from d9c8aea to 6b1c3cb Compare July 16, 2025 09:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 45 lines in your changes missing coverage. Please review.

Project coverage is 50.37%. Comparing base (e520e64) to head (a69be92).

Files with missing lines Patch % Lines
packages/core/src/server-discovery/discovery.ts 73.88% 41 Missing ⚠️
packages/core/src/utils/makeRequest.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   51.19%   50.37%   -0.83%     
==========================================
  Files          77       76       -1     
  Lines        8141     7961     -180     
==========================================
- Hits         4168     4010     -158     
+ Misses       3973     3951      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@debdutdeb debdutdeb marked this pull request as ready for review July 16, 2025 09:23
@debdutdeb debdutdeb force-pushed the one-serverResolution branch from 6b1c3cb to d8c46e9 Compare July 16, 2025 09:35
@debdutdeb debdutdeb force-pushed the one-serverResolution branch from 5ed0aa1 to 21f96c2 Compare July 23, 2025 13:00
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ debdutdeb
❌ Marcos Spessatto Defendi


Marcos Spessatto Defendi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove server discovery duplicity

4 participants