Skip to content

Move all private (set) variables to non_private_items.  #17

@rresma2

Description

@rresma2

Hi Paul, I'd like feedback on the following change as well as permissions to PR if possible.

Currently in Master

non_private_items, private_items = file_items.partition {  |f|
    !f.modifiers.include?("private") 
        && !f.modifiers.include?("fileprivate") 
}

Proposed Change

private_items, non_private_items = file_items.partition { |f|
    (
        f.modifiers.include?("private")
            && !f.modifiers.include?("(set)")
    ) || (
            f.modifiers.include?("fileprivate")
    )
}

Basically I want to make sure to only count private items if they don't contain (set).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions