Hi Paul, I'd like feedback on the following change as well as permissions to PR if possible.
Currently in Master
non_private_items, private_items = file_items.partition { |f|
!f.modifiers.include?("private")
&& !f.modifiers.include?("fileprivate")
}
Proposed Change
private_items, non_private_items = file_items.partition { |f|
(
f.modifiers.include?("private")
&& !f.modifiers.include?("(set)")
) || (
f.modifiers.include?("fileprivate")
)
}
Basically I want to make sure to only count private items if they don't contain (set).