Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 6, 2025

Overview

update Storybook from v7 to v8

remove actions: { argTypesRegex: '^on[A-Z].*' }, from preview.tsx since Storybook doesn't recommend users to use that.

AUTH-2483

Test Plan and Hands on Testing

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

  • update Storybook version from 7 to 8
  • update preview.tsx

Review requests

Risk assessment

low

@koji koji changed the base branch from edge to chore_change-package-manager December 6, 2025 22:01
@koji koji marked this pull request as ready for review December 6, 2025 22:01
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.29%. Comparing base (60f9838) to head (f4a0add).

Files with missing lines Patch % Lines
.storybook/main.ts 0.00% 13 Missing ⚠️
.storybook/preview.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           chore_change-package-manager   #20313       +/-   ##
=================================================================
+ Coverage                         24.62%   57.29%   +32.67%     
=================================================================
  Files                              3564     3564               
  Lines                            295541   295576       +35     
  Branches                          42503    42637      +134     
=================================================================
+ Hits                              72774   169349    +96575     
+ Misses                           222739   125999    -96740     
- Partials                             28      228      +200     
Flag Coverage Δ
app 46.20% <0.00%> (+45.90%) ⬆️
protocol-designer 19.20% <0.00%> (-0.01%) ⬇️
step-generation 5.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.storybook/preview.tsx 0.00% <0.00%> (ø)
.storybook/main.ts 0.00% <0.00%> (-3.71%) ⬇️

... and 1884 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested a review from a team as a code owner December 6, 2025 23:36
@koji koji closed this Dec 7, 2025
@koji koji deleted the chore_update-storybook-v8 branch December 7, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants