International support methods - 国际化支持方式 #5433
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
|
Looks like there are conflicts on this branch. Please fix them. Thanks. |
| props: { | ||
| icon: 'tool-move', | ||
| label: 'Pan', | ||
| label: 'Buttons:Pan', |
There was a problem hiding this comment.
This is not a bad approach, however we currently are using i18n right in the various toolbarButton files. I think once you update your branch you will see what I mean. Or see this:
There was a problem hiding this comment.
These changes will no longer be needed once you switch to the standard way we do i18n. Thanks.
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
Thanks for this effort. See my comments.
|
@jbocce not my business, but shouldn’t commit messages be in English for readability? Also, having the PR description in English would be great so anyone can reference it later. I’ve lost count of how many times I had to dig through old PRs just to understand what was going on while fixing or investigating an issue. |
@pedrokohler You make a good point. I respectfully used Google translate to translate what was there for the PR and left the original text too. As for the commit message, I will discuss with the core OHIF members. Thank you. |
3 participants
Description
This pull request aims to improve the project's internationalization (i18n) support, ensuring that all previously unsupported components are now internationalized.
Changes
描述
本 PR 旨在修改项目的国际化 (i18n) 支持，使未支持国际化的部分，都能支持国际化。
修改内容
- 组件国际化：对核心组件中的静态文本进行了国际化改造，使用 $t('key')方法替换硬编码文本。