Convert html img attributes to markdown image

[lassoan]

Most images that are imported from github issue appear distorted in the github pages after conversion. The issue is that images are displayed using html <img> tag instead of markdown image ![](url).

I've fixed up the existing errors in this commit, but it would be better to avoid this error by automatically converting the html img tag during conversion.

[sjh26]

So, we did not have this issue last project week, and nothing has changed about the issue -> project pr -> page process since then. It is github itself that is inserting the <img> tag rather than ![](), see source of below, which I drag and dropped. That process used to generate the markdown version:

[sjh26]

Also, the distortion will only occur if the image size set in the tag is too big. If it fits it behaves normally.

[lassoan]

To add images into a markdown table it may be necessary to use <img> tag.

[sjh26]

Yes, I don't think there is any easy fix to this, this is a change of behavior of GitHub, and we have some cases where we want to use <img>

[lassoan]

Yes, in exceptional cases authors can introduce <img> if they want.

Related issue: URL of image attachments in github issues are not guaranteed to be persistent (they changed in the past) and the attached files may be deleted when issue is deleted, repository is moved, etc. So, we should make a copy of the image in the repository for archival purposes (and also to make the repository usable offline). Of course, the disadvantage is that the repository gets larger, but I think it is worth it.

[sjh26]

Yes, in exceptional cases authors can introduce <img> if they want.

But if we are autoconverting during the page generation process then they can't, it will get converted to markdown format. We could decide to only convert when going from issue to PR, but the same <img> problem occurs when editing existing pages from github.

[sjh26]

So, we should make a copy of the image in the repository for archival purposes

We can do this for the issue -> pr pipeline

[lassoan]

Markdown tables will not be used often if we don't use them in the template, but in case it becomes a problem it should not be hard to make the converter not touch markdown table content.

So, we should make a copy of the image in the repository for archival purposes

We can do this for the issue -> pr pipeline

That would be great!

[lassoan]

It seems that markdown image does work in markdown table - see https://projectweek.na-mic.org/PW40_2024_GranCanaria/Projects/NewInteractionWidgetForTransformsMarkups/#existing-widgets

The problem is with this specific page, due to markdown images are being in a HTML table. Fixed it by switching to using markdown table.