Merge pull request #789 from eaguad1337/fix/768

Fixes add_query_params on str.py

Author: josephmancuso

src/masonite/utils/str.py

@@ -80,17 +80,18 @@ def add_query_params(url: str, query_params: dict) -> str:
     """Add query params dict to a given url (which can already contain some query parameters)."""
     path_result = parse.urlsplit(url)
 
-    base_url = path_result.path
+    base_url = f"{path_result.scheme}://{path_result.hostname}" if path_result.hostname else ""
+    base_path = path_result.path
 
     # parse existing query parameters if any
     existing_query_params = dict(parse.parse_qsl(path_result.query))
     all_query_params = {**existing_query_params, **query_params}
 
     # add query parameters to url if any
     if all_query_params:
-        base_url += "?" + parse.urlencode(all_query_params)
+        base_path += "?" + parse.urlencode(all_query_params)
 
-    return base_url
+    return f"{base_url}{base_path}"
 
 
 def get_controller_name(controller: "str|Any") -> str:

tests/core/response/test_response_redirections.py

@@ -34,3 +34,13 @@ def test_redirect_to_url(self):
         self.assertEqual(
             self.response.header_bag.get("Location").value, "/login?key=value"
         )
+
+    def test_redirect_to_external_url(self):
+        self.response.redirect(url="https://google.cl/login")
+        self.assertEqual(self.response.get_status(), 302)
+        self.assertEqual(self.response.header_bag.get("Location").value, "https://google.cl/login")
+
+        self.response.redirect(url="https://google.cl/login", query_params={"key": "value"})
+        self.assertEqual(
+            self.response.header_bag.get("Location").value, "https://google.cl/login?key=value"
+        )