Missing ycbcr2plane444Formats VUs

[spencer-lunarg]

In 1.4.337 the following VUs were added

• VUID-vkGetPhysicalDeviceFormatProperties-None-12272
• VUID-vkGetPhysicalDeviceFormatProperties2-None-12273
• VUID-VkDescriptorAddressInfoEXT-None-12271
• VUID-VkBufferViewCreateInfo-None-12278
• VUID-VkImageCreateInfo-None-12279
• VUID-VkImageViewCreateInfo-None-12280

Added in https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6922

[spencer-lunarg]

test for the future

TEST_F(VkLayerTest, Ycbcr2plane444Formats) {
    SetTargetApiVersion(VK_API_VERSION_1_1);
    RETURN_IF_SKIP(Init());

    VkFormatProperties format_properties;
    vk::GetPhysicalDeviceFormatProperties(Gpu(), VK_FORMAT_G8_B8R8_2PLANE_444_UNORM, &format_properties);

    VkFormatProperties2 format_properties2 = vku::InitStructHelper();
    vk::GetPhysicalDeviceFormatProperties2(Gpu(), VK_FORMAT_G8_B8R8_2PLANE_444_UNORM, &format_properties2);
}

[arno-lunarg]

Is assigning me a YCbCr related issue your "merry christmas" to me?!?!

[spencer-lunarg]

it has nothing to do with YCbCr, just using things when a feature is not enabled... it actually is more like #10747

[arno-lunarg]

For VUID-VkBufferViewCreateInfo-None-12278 I already get a VU:

Validation Error: [ VUID-VkBufferViewCreateInfo-format-parameter ] | MessageID = 0x5e1fd8ef
vkCreateBufferView(): pCreateInfo->format (VK_FORMAT_G16_B16R16_2PLANE_444_UNORM) requires the extensions VK_EXT_ycbcr_2plane_444_formats.
The Vulkan spec states: format must be a valid VkFormat value (https://docs.vulkan.org/spec/latest/chapters/resources.html#VUID-VkBufferViewCreateInfo-format-parameter)

So 12278 looks redundant?
(spec link: https://docs.vulkan.org/refpages/latest/refpages/source/VkBufferViewCreateInfo.html#VUID-VkBufferViewCreateInfo-None-12278)

[spencer-lunarg]

I brought this up when it was being added

so the 12278 is a bit... dumb IMO, it is checking the case, you have VK_EXT_ycbcr_2plane_444_formats enabled, on a vulkan 1.2 device, but not enabled the feature

honestly this is just ugly because of how trying to add formats are

... just feel free to do a SetAllowedFailureMsg("VUID-VkBufferViewCreateInfo-format-parameter") and leave a comment here in the test

[arno-lunarg]

Given how VVL works, with generated stateless validation taking precedence and all that jazz, I don't think we can even get to 12278

I have this test:

TEST_F(NegativeBuffer, BufferViewYcbCr2Plane) {
    TEST_DESCRIPTION("Attempt to create a buffer view with invalid create info.");
    SetTargetApiVersion(VK_API_VERSION_1_2);
    RETURN_IF_SKIP(Init());
    AddRequiredExtensions(VK_EXT_YCBCR_2PLANE_444_FORMATS_EXTENSION_NAME);

    vkt::Buffer buffer(*m_device, 4096, VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT);
    VkBufferViewCreateInfo buff_view_ci = vku::InitStructHelper();
    buff_view_ci.buffer = buffer;
    buff_view_ci.offset = 0;
    buff_view_ci.format = VK_FORMAT_G16_B16R16_2PLANE_444_UNORM;
    CreateBufferViewTest(buff_view_ci, "VUID-VkBufferViewCreateInfo-format-parameter");
}

And it is green => I don't get 12278, just VUID-VkBufferViewCreateInfo-format-parameter

Expected, given our generated code skips manual stateless validation if skip is set to true

[spencer-lunarg]

If you use SetAllowedFailureMsg it will get through the stateless validation, we have done it before

[arno-lunarg]

ah ok!