Categories - Missing right caret on category row

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.97-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77776
Email or phone of affected tester (no customers): sdsoidjnosnjdsodsjno@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Category.

Expected Result:

Right caret is shown at the right end of category row.

Actual Result:

Right caret is missing on the category row.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #77776

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #77776 - "Make SelectionListWithModal use new SelectionList" by @zfurtak (High confidence)
Related Issues: None found

Recommendation: REVERT

The PR migrated SelectionListWithModal from the old SelectionListWithSections to the new SelectionList component. During this migration, the code that renders the right caret icon was lost.

📋 Detailed Analysis

Evidence

The issue reports that the right caret is missing on category rows in Workspace Settings > Category. The bug is reproducible on staging but not production, and the issue description explicitly links to PR #77776 as the bug source.

By comparing the old and new implementations:

• Old code (SelectionListWithSections/BaseListItem.tsx lines 168-178): Had explicit code to render the right caret when shouldShowRightCaret={true}:

{shouldShowRightCaret && (
    <View style={[styles.justifyContentCenter, styles.alignItemsCenter, styles.ml2]}>
        <Icon
            src={icons.ArrowRight}
            fill={theme.icon}
            additionalStyles={[styles.alignSelfCenter, !hovered && styles.opacitySemiTransparent]}
            isButtonIcon
            medium
        />
    </View>
)}

• New code (SelectionList/ListItem/BaseListItem.tsx): The shouldShowRightCaret prop is completely missing from the component - it's not accepted as a prop and has no rendering logic for it.

The WorkspaceCategoriesPage.tsx correctly passes shouldShowRightCaret prop to SelectionListWithModal (line 666), and the prop is passed down through TableListItem (line 85) to BaseListItem (line 85), but the new BaseListItem doesn't handle this prop at all.

Root Cause

During the migration from SelectionListWithSections to the new SelectionList component architecture, the caret rendering logic was not ported over to the new SelectionList/ListItem/BaseListItem.tsx. The old BaseListItem had the shouldShowRightCaret prop and rendered an ArrowRight icon when true, but this entire block of code (including the lazy icon loading and conditional rendering) was omitted from the new implementation.

This affects all pages using SelectionListWithModal with shouldShowRightCaret={true}, including:

• WorkspaceCategoriesPage
• PolicyDistanceRatesPage
• WorkspacePerDiemPage
• ReportFieldsListValuesPage
• WorkspaceTagsPage
• WorkspaceViewTagsPage
• WorkspaceTaxesPage
• ExpenseRulesPage
• ReportParticipantsPage
• RoomMembersPage
• WorkspaceMembersPage