-
Notifications
You must be signed in to change notification settings - Fork 492
chore(config/tracer): migrate noDebugStack #4223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2025-12-05 19:19:42 Comparing candidate commit 711fc50 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. |
| func WithDebugStack(enabled bool) StartOption { | ||
| return func(c *config) { | ||
| c.noDebugStack = !enabled | ||
| c.internalConfig.SetDebugStack(enabled, telemetry.OriginCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarity + documentation purposes: this new config now says true if we DO want the debug stack, whereas before we said true if we did NOT want the debug stack? 😵 💫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see the "debugStack enables the collection..." in the docstring below. Thanks for the documentation!
What does this PR do?
Tracer migrates to using Config.noDebugStack instead of its own config.noDebugStack.
Motivation
https://datadoghq.atlassian.net/browse/APMAPI-1748
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!