Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 5, 2025

What does this PR do?

Tracer migrates to using Config.noDebugStack instead of its own config.noDebugStack.

Motivation

https://datadoghq.atlassian.net/browse/APMAPI-1748

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2025

Benchmarks

Benchmark execution time: 2025-12-05 19:19:42

Comparing candidate commit 711fc50 in PR branch mtoff/noDebugStack with baseline commit 8eb1f41 in branch mtoff/revamp-debug-api.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

@mtoffl01 mtoffl01 marked this pull request as ready for review December 5, 2025 18:44
@mtoffl01 mtoffl01 requested review from a team as code owners December 5, 2025 18:44
@mtoffl01 mtoffl01 changed the base branch from main to mtoff/revamp-debug-api December 5, 2025 18:44
func WithDebugStack(enabled bool) StartOption {
return func(c *config) {
c.noDebugStack = !enabled
c.internalConfig.SetDebugStack(enabled, telemetry.OriginCode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity + documentation purposes: this new config now says true if we DO want the debug stack, whereas before we said true if we did NOT want the debug stack? 😵 💫

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the "debugStack enables the collection..." in the docstring below. Thanks for the documentation!

@mtoffl01 mtoffl01 marked this pull request as draft December 5, 2025 19:17
Base automatically changed from mtoff/revamp-debug-api to main December 9, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants