Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 3, 2025

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 3, 2025

Benchmarks

Benchmark execution time: 2025-12-03 20:00:27

Comparing candidate commit 6075f08 in PR branch mtoff/migrate-agenturl with baseline commit e12fcf6 in branch mtoff/revamp-debug-api.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 3, 2025

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

TestMain from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

PASS
coverage: 67.9% of statements
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 142398 in state IO wait, with internal/poll.runtime_pollWait on top of the stack:
internal/poll.runtime_pollWait(0x7f42421c7eb0, 0x72)
	/opt/hostedtoolcache/go/1.24.11/x64/src/runtime/netpoll.go:351 +0x85
internal/poll.(*pollDesc).wait(0xc00039cda0, 0x72, 0x0)
	/opt/hostedtoolcache/go/1.24.11/x64/src/internal/poll/fd_poll_runtime.go:84 +0xb1
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6075f08 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants