Skip to content

Conversation

@raouf-haddada
Copy link
Contributor

@raouf-haddada raouf-haddada commented Dec 5, 2025

  • [redis] use fqdn for sentinel redis replicas, to avoid problems when calling it cross namespaces
    recognized replicas fqdn
$ redis-cli -p 26379 -h redis-cloud-pirates-headless.redis
redis-cloud-pirates-headless.redis:26379> sentinel replicas redis-master
1)  1) "name"
    2) "redis-cloud-pirates-2.redis-cloud-pirates-headless.redis.svc.cluster.local:6379"
    3) "ip"
    4) "redis-cloud-pirates-2.redis-cloud-pirates-headless.redis.svc.cluster.local"
    5) "port"
    6) "6379"
    7) "runid"
    8) "f352db09cc6a2bae2f13a9d6c397bfe47f9d1db9"
    9) "flags"
   10) "slave"
   11) "link-pending-commands"
   12) "0"
   13) "link-refcount"
   14) "1"
   15) "last-ping-sent"
   16) "0"
   17) "last-ok-ping-reply"
   18) "640"
   19) "last-ping-reply"
   20) "640"
   21) "down-after-milliseconds"
   22) "5000"
   23) "info-refresh"
   24) "6860"
   25) "role-reported"
   26) "slave"
   27) "role-reported-time"
   28) "14213"
   29) "master-link-down-time"
   30) "0"
   31) "master-link-status"
   32) "ok"
   33) "master-host"
   34) "redis-cloud-pirates-0.redis-cloud-pirates-headless.redis.svc.cluster.local"
   35) "master-port"
   36) "6379"
   37) "slave-priority"
   38) "100"
   39) "slave-repl-offset"
   40) "12411"
   41) "replica-announced"
   42) "1"
2)  1) "name"
    2) "redis-cloud-pirates-1.redis-cloud-pirates-headless.redis.svc.cluster.local:6379"
    3) "ip"
    4) "redis-cloud-pirates-1.redis-cloud-pirates-headless.redis.svc.cluster.local"
    5) "port"
    6) "6379"
    7) "runid"
    8) "aa47a57e2d5758bee67ee8bdb271cff3870e3341"
    9) "flags"
   10) "slave"
   11) "link-pending-commands"
   12) "0"
   13) "link-refcount"
   14) "1"
   15) "last-ping-sent"
   16) "0"
   17) "last-ok-ping-reply"
   18) "757"
   19) "last-ping-reply"
   20) "757"
   21) "down-after-milliseconds"
   22) "5000"
   23) "info-refresh"
   24) "78"
   25) "role-reported"
   26) "slave"
   27) "role-reported-time"
   28) "44372"
   29) "master-link-down-time"
   30) "0"
   31) "master-link-status"
   32) "ok"
   33) "master-host"
   34) "redis-cloud-pirates-0.redis-cloud-pirates-headless.redis.svc.cluster.local"
   35) "master-port"
   36) "6379"
   37) "slave-priority"
   38) "100"
   39) "slave-repl-offset"
   40) "15091"
   41) "replica-announced"
   42) "1"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

⚠️ Unsigned Commits Detected

This pull request contains unsigned commits.

What does this mean?

Signed commits help ensure the authenticity and traceability of contributions. They allow us to verify that commits actually came from the stated author, even if GitHub accounts are deleted or modified in the future.

Current Policy (Grace Period)

This is currently a warning only. We are in a transition period to give all contributors time to set up commit signing.

After this grace period, all commits will be required to be signed before PRs can be merged.

How to sign your commits

Please see our Contributing Guide for detailed instructions on setting up commit signing.

Resources


This check will become mandatory in the future. Please start signing your commits now to avoid issues later.

* [redis] use fqdn for sentinel redis replicas, to avoid problems when calling it cross namespaces
@raouf-haddada raouf-haddada force-pushed the bugfix/redis-sentinel-fqdn branch from deba23c to a962c04 Compare December 5, 2025 18:49
Copy link
Collaborator

@mms-gianni mms-gianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zOnlyKroks zOnlyKroks merged commit 76a4a10 into CloudPirates-io:main Dec 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants