frontend: propose swap api #3709
Conversation
thisconnect
force-pushed
the
frontend-swap-api
branch
from
b0e01cc to
351d326
Compare
| }; | ||
|
|
||
| export const getSwapState = (): Promise<TSwapQuotes> => { | ||
| return apiGet('swap/state'); |
There was a problem hiding this comment.
(I know this is just a draft, but I thought I'd take a look)
I'm not sure I understand the purpose of this endpoint. What's the intended flow here?
Frontend calls quote, gets a quote id, user selects the quote they want, frontend calls swap (called execute here). At what point in "state" called?
There was a problem hiding this comment.
It's just a draft but a good moment to discuss. Feel free to open a PR or comment here what I should change.
Does the quote stay the same forever? Or do we need a way that the backend can push updates to the quote if anything changes?
If a quote stays forever the same we can just return the data (TSwapQuotes or TSwapQuotes[]) via the POST request. But if the backend needs to be able to inform the frontend and push updates to the quotes, then we need some subscription.
2 participants
First rought shot at how the swap api between backend<->frontend could look like.